Skip to content

Migrate from circleci to github actions#217

Merged
thodkatz merged 7 commits intomainfrom
ci-multiple-os
Sep 16, 2024
Merged

Migrate from circleci to github actions#217
thodkatz merged 7 commits intomainfrom
ci-multiple-os

Conversation

@thodkatz
Copy link
Collaborator

@thodkatz thodkatz commented Sep 4, 2024

No description provided.

@thodkatz thodkatz mentioned this pull request Sep 4, 2024
Closed
@thodkatz thodkatz marked this pull request as draft September 4, 2024 09:09
@thodkatz thodkatz force-pushed the ci-multiple-os branch 27 times, most recently from ceb85a6 to 8f2fbc4 Compare September 4, 2024 15:45
@thodkatz
Copy link
Collaborator Author

thodkatz commented Sep 5, 2024 •
edited
Loading 

 13:01:17.520 [MainProcess/ThreadPoolExecutor-2_0] ERROR Error during close handler for session 6bb644f657014d02ac91995aec4aaf7a
Traceback (most recent call last):
  File "$SRC_DIR/tiktorch/server/session_manager.py", line 79, in close_session
    handler()
  File "$SRC_DIR/tiktorch/rpc/mp.py", line 99, in __call__
    return fut.result(timeout=timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "$SRC_DIR/tiktorch/rpc/types.py", line 82, in result
    return super().result(timeout or self._timeout)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "$PREFIX/lib/python3.12/concurrent/futures/_base.py", line 456, in result
    return self.__get_result()
           ^^^^^^^^^^^^^^^^^^^
  File "$PREFIX/lib/python3.12/concurrent/futures/_base.py", line 401, in __get_result
    raise self._exception
  File "$SRC_DIR/tiktorch/rpc/mp.py", line 145, in _poller
    msg = self._conn.recv()
          ^^^^^^^^^^^^^^^^^
  File "$PREFIX/lib/python3.12/multiprocessing/connection.py", line 250, in recv
    buf = self._recv_bytes()
          ^^^^^^^^^^^^^^^^^^
  File "$PREFIX/lib/python3.12/multiprocessing/connection.py", line 430, in _recv_bytes
    buf = self._recv(4)
          ^^^^^^^^^^^^^
  File "$PREFIX/lib/python3.12/multiprocessing/connection.py", line 399, in _recv
    raise EOFError

@thodkatz thodkatz mentioned this pull request Sep 9, 2024
Merged
@thodkatz thodkatz force-pushed the ci-multiple-os branch 15 times, most recently from 969cc47 to 85feeac Compare September 12, 2024 18:06
@thodkatz
Copy link
Collaborator Author

thodkatz commented Sep 12, 2024 •
edited
Loading

I think finally it is good to go. The macos and windows workflows fail due to the pickle issue mentioned and resolved here #212. We can either merge the #212 and after this or the reverse :P

I have spoted and resolved another issue (54b4c96) similar to the #218, where if a test fails the process isn't closed.

I have deleted the circlie ci config as well, we can unlink the repo with the circle ci...

@thodkatz thodkatz marked this pull request as ready for review September 12, 2024 18:12
k-dominik
k-dominik reviewed Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@k-dominik k-dominik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thodkatz,

I think this looks great over all, small changes would be appreciated though. And I think it's fine to merge this one first, rebase #212 on the new main and fix tests there.

@thodkatz
Copy link
Collaborator Author

thodkatz commented Sep 16, 2024 •
edited
Loading

Okey, I think I have addressed the comments, and the ci is failing only for the pickle issue :) Let me know @k-dominik, and thank you very much!

k-dominik
k-dominik approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@k-dominik k-dominik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@k-dominik k-dominik k-dominik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thodkatz @k-dominik